[SDK] Feature: Adds SiteLink component #5326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
edwardysun,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: f5f5ae6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
size-limit report 📦
|
gregfromstl
force-pushed
the
greg/cnct-2259-sitelink-component
branch
from
33afacc to
f812794
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5326 +/- ##
==========================================
+ Coverage 45.71% 45.75% +0.03%
==========================================
Files 1068 1069 +1
Lines 55560 55606 +46
Branches 4063 4074 +11
==========================================
+ Hits 25402 25444 +42
- Misses 29469 29473 +4
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
added
Request
Contributor
Author
Merge activity
|
joaquim-verges
approved these changes
Nov 6, 2024
Completes CNCT-2259 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces the `SiteLink` component to facilitate wallet-aware linking between thirdweb-enabled sites, enhancing user experience by sharing wallet state seamlessly. It also updates the `SiteEmbed` component documentation and includes tests for the new `SiteLink`. ### Detailed summary - Updated comment for `SiteEmbed` to reflect wallet connection usage. - Added `SiteLink` component for creating links with wallet parameters. - Provided usage example for `SiteLink` in documentation. - Implemented tests for `SiteLink` to verify functionality and error handling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2259-sitelink-component
branch
from
f812794 to
f5f5ae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes CNCT-2259
PR-Codex overview
This PR introduces a new component,
SiteLink, which allows users to create wallet-aware links between thirdweb-enabled sites. It enhances the existing functionality by automatically appending wallet connection parameters to the target URL when a wallet is connected.Detailed summary
SiteEmbedto include linking functionality.SiteLinkfrom../react/web/ui/SiteLink.js.SiteLinkcomponent for creating wallet-aware links.SiteEmbeddocumentation to clarify prop usage.SiteLinkto ensure correct rendering and error handling.SiteLinkbased on connection status.